From dev-return-74942-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Wed Oct 24 11:47:39 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 972ED180638 for ; Wed, 24 Oct 2018 11:47:38 +0200 (CEST) Received: (qmail 25573 invoked by uid 500); 24 Oct 2018 09:47:32 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 25561 invoked by uid 99); 24 Oct 2018 09:47:32 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Oct 2018 09:47:32 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id EE7BFDFA5C; Wed, 24 Oct 2018 09:47:31 +0000 (UTC) From: maoling To: dev@zookeeper.apache.org Reply-To: dev@zookeeper.apache.org References: In-Reply-To: Subject: [GitHub] zookeeper issue #667: ZOOKEEPER-3158:firstConnect.countDown() will not be ex... Content-Type: text/plain Message-Id: <20181024094731.EE7BFDFA5C@git1-us-west.apache.org> Date: Wed, 24 Oct 2018 09:47:31 +0000 (UTC) Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/667 @eolivelli @dineshappavoo you're right. I was mislead by `void primeConnection() throws IOException` which don't throw an IOException. But,Follow the paradigm,put the `firstConnect.countDown()` into `finally` block is better? ---