From dev-return-74843-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org  Fri Oct 19 21:24:21 2018
Return-Path: <dev-return-74843-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 8BE92180652
	for <archive-asf-public@cust-asf.ponee.io>; Fri, 19 Oct 2018 21:24:21 +0200 (CEST)
Received: (qmail 26133 invoked by uid 500); 19 Oct 2018 19:24:20 -0000
Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@zookeeper.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@zookeeper.apache.org>
List-Post: <mailto:dev@zookeeper.apache.org>
List-Id: <dev.zookeeper.apache.org>
Reply-To: dev@zookeeper.apache.org
Delivered-To: mailing list dev@zookeeper.apache.org
Received: (qmail 26122 invoked by uid 99); 19 Oct 2018 19:24:19 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Oct 2018 19:24:19 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id D6B74DFC65; Fri, 19 Oct 2018 19:24:19 +0000 (UTC)
From: ivmaykov <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-669-zookeeper@git.apache.org>
In-Reply-To: <git-pr-669-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #669: ZOOKEEPER-3152: Port ZK netty stack to netty4
Content-Type: text/plain
Message-Id: <20181019192419.D6B74DFC65@git1-us-west.apache.org>
Date: Fri, 19 Oct 2018 19:24:19 +0000 (UTC)

Github user ivmaykov commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/669#discussion_r226756739
  
    --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxn.java ---
    @@ -200,24 +186,13 @@ public void setSessionId(long sessionId) {
             this.sessionId = sessionId;
         }
     
    -    @Override
    -    public void enableRecv() {
    -        if (throttled) {
    -            throttled = false;
    -            if (LOG.isDebugEnabled()) {
    -                LOG.debug("Sending unthrottle event " + this);
    -            }
    -            channel.getPipeline().sendUpstream(new ResumeMessageEvent(channel));
    -        }
    -    }
    -
         @Override
         public void sendBuffer(ByteBuffer sendBuffer) {
             if (sendBuffer == ServerCnxnFactory.closeConn) {
                 close();
                 return;
             }
    -        channel.write(wrappedBuffer(sendBuffer));
    +        channel.writeAndFlush(Unpooled.wrappedBuffer(sendBuffer));
    --- End diff --
    
    As above, I'm not sure what that provides. I am still learning about netty so please excuse my ignorance :)


---