From dev-return-74679-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org  Tue Oct 16 09:11:04 2018
Return-Path: <dev-return-74679-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 1A499180649
	for <archive-asf-public@cust-asf.ponee.io>; Tue, 16 Oct 2018 09:11:03 +0200 (CEST)
Received: (qmail 26173 invoked by uid 500); 16 Oct 2018 07:11:02 -0000
Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@zookeeper.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@zookeeper.apache.org>
List-Post: <mailto:dev@zookeeper.apache.org>
List-Id: <dev.zookeeper.apache.org>
Reply-To: dev@zookeeper.apache.org
Delivered-To: mailing list dev@zookeeper.apache.org
Received: (qmail 26162 invoked by uid 99); 16 Oct 2018 07:11:02 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Oct 2018 07:11:02 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 1336CDFD6B; Tue, 16 Oct 2018 07:11:02 +0000 (UTC)
From: nkalmar <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-670-zookeeper@git.apache.org>
In-Reply-To: <git-pr-670-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #670: DO_NOT_MERGE - MAVEN MIGRATION - Separation of ...
Content-Type: text/plain
Message-Id: <20181016071102.1336CDFD6B@git1-us-west.apache.org>
Date: Tue, 16 Oct 2018 07:11:02 +0000 (UTC)

Github user nkalmar commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/670#discussion_r225420204
  
    --- Diff: zookeeper-client/zookeeper-client-java/pom.xml ---
    @@ -0,0 +1,59 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
    +<!--
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +-->
    +  <modelVersion>4.0.0</modelVersion>
    +  <parent>
    +    <groupId>org.apache.zookeeper</groupId>
    +    <artifactId>zookeeper</artifactId>
    +    <version>2.6.0-SNAPSHOT</version>
    --- End diff --
    
    Yes, it was like this on the master pom... I will definitely fix it in a "real" PR.


---