From dev-return-74388-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Wed Oct 10 00:53:55 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1A056180668 for ; Wed, 10 Oct 2018 00:53:54 +0200 (CEST) Received: (qmail 46749 invoked by uid 500); 9 Oct 2018 22:53:54 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 46727 invoked by uid 99); 9 Oct 2018 22:53:53 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Oct 2018 22:53:53 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 640F3DFE14; Tue, 9 Oct 2018 22:53:53 +0000 (UTC) From: enixon To: dev@zookeeper.apache.org Reply-To: dev@zookeeper.apache.org References: In-Reply-To: Subject: [GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe... Content-Type: text/plain Message-Id: <20181009225353.640F3DFE14@git1-us-west.apache.org> Date: Tue, 9 Oct 2018 22:53:53 +0000 (UTC) Github user enixon commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r223888479 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java --- @@ -84,8 +84,12 @@ public Socket getSocket() { protected static final Logger LOG = LoggerFactory.getLogger(Learner.class); + private static final int leaderConnectDelayDuringRetryMs = + Integer.getInteger("zookeeper.leaderConnectDelayDuringRetryMs", 100); --- End diff -- The change was inspired by an Observer potentially taking a long time to recover after a leader election if the first LearnerMaster that it hooked in to was a Follower that was lagging in syncing with the leader. Rather than fixate on this slow Follower, the Observer can be moved along to a new LearnerMaster with minimal delay. ---