From dev-return-74261-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org  Sat Oct  6 14:43:27 2018
Return-Path: <dev-return-74261-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id C05ED180677
	for <archive-asf-public@cust-asf.ponee.io>; Sat,  6 Oct 2018 14:43:26 +0200 (CEST)
Received: (qmail 84365 invoked by uid 500); 6 Oct 2018 12:43:25 -0000
Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@zookeeper.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@zookeeper.apache.org>
List-Post: <mailto:dev@zookeeper.apache.org>
List-Id: <dev.zookeeper.apache.org>
Reply-To: dev@zookeeper.apache.org
Delivered-To: mailing list dev@zookeeper.apache.org
Received: (qmail 83752 invoked by uid 99); 6 Oct 2018 12:43:25 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 06 Oct 2018 12:43:25 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id AEAF6DFBE8; Sat,  6 Oct 2018 12:43:24 +0000 (UTC)
From: eolivelli <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-632-zookeeper@git.apache.org>
In-Reply-To: <git-pr-632-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #632: [ZOOKEEPER-3150] Add tree digest check and veri...
Content-Type: text/plain
Message-Id: <20181006124324.AEAF6DFBE8@git1-us-west.apache.org>
Date: Sat,  6 Oct 2018 12:43:24 +0000 (UTC)

Github user eolivelli commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/632#discussion_r223181383
  
    --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java ---
    @@ -1521,4 +1562,179 @@ public boolean removeWatch(String path, WatcherType type, Watcher watcher) {
         public ReferenceCountedACLCache getReferenceCountedAclCache() {
             return aclCache;
         }
    +
    +    /**
    +     * Add the digest to the historical list, and update the latest zxid digest.
    +     */
    +    private void logZxidDigest(long zxid, long digest) {
    +        ZxidDigest zxidDigest = new ZxidDigest(zxid, DigestCalculator.DIGEST_VERSION, digest);
    +        lastProcessedZxidDigest = zxidDigest;
    +        if (zxidDigest.zxid % 128 == 0) {
    --- End diff --
    
    Can you explain this magic value '128' ? Maybe a comment will help.
    
    Maybe I am missing something


---