From dev-return-74003-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Tue Oct 2 12:04:53 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 418A0180638 for ; Tue, 2 Oct 2018 12:04:53 +0200 (CEST) Received: (qmail 4425 invoked by uid 500); 2 Oct 2018 10:04:52 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 4409 invoked by uid 99); 2 Oct 2018 10:04:51 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Oct 2018 10:04:51 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 7DF80DFEAD; Tue, 2 Oct 2018 10:04:51 +0000 (UTC) From: maoling To: dev@zookeeper.apache.org Reply-To: dev@zookeeper.apache.org References: In-Reply-To: Subject: [GitHub] zookeeper issue #624: ZOOKEEPER-3108:use a new property server.id in the zoo... Content-Type: text/plain Message-Id: <20181002100451.7DF80DFEAD@git1-us-west.apache.org> Date: Tue, 2 Oct 2018 10:04:51 +0000 (UTC) Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/624 @lvfangmin read the [doc](http://zookeeper.apache.org/doc/r3.5.1-alpha/zookeeperReconfig.html) and the code in the `QuorumPeerConfig.parseDynamicConfig()`,IMO,the` server.id` is only to be one of the static config and not included into the dynamic config file.WDYT? ---