From dev-return-73992-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Tue Oct 2 08:31:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 207C0180638 for ; Tue, 2 Oct 2018 08:31:04 +0200 (CEST) Received: (qmail 56895 invoked by uid 500); 2 Oct 2018 06:31:03 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 56873 invoked by uid 99); 2 Oct 2018 06:31:02 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Oct 2018 06:31:02 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 51DFADFF32; Tue, 2 Oct 2018 06:31:02 +0000 (UTC) From: lvfangmin To: dev@zookeeper.apache.org Reply-To: dev@zookeeper.apache.org References: In-Reply-To: Subject: [GitHub] zookeeper pull request #652: ZOOKEEPER-3156: Add in option to canonicalize h... Content-Type: text/plain Message-Id: <20181002063102.51DFADFF32@git1-us-west.apache.org> Date: Tue, 2 Oct 2018 06:31:02 +0000 (UTC) Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/652#discussion_r221836418 --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java --- @@ -793,7 +794,87 @@ public RWServerFoundException(String msg) { super(msg); } } - + + static class MockableInetSocketAddress { --- End diff -- It's adding too much complexity to the code in order to test it, are we able to create the stub to extend the InetSocketAddress in the test case itself? ---