zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nkalmar <...@git.apache.org>
Subject [GitHub] zookeeper pull request #670: DO_NOT_MERGE - MAVEN MIGRATION - Separation of ...
Date Mon, 15 Oct 2018 21:21:54 GMT
GitHub user nkalmar opened a pull request:

    https://github.com/apache/zookeeper/pull/670

    DO_NOT_MERGE - MAVEN MIGRATION - Separation of server and client

    This is to show that unlike I thought at the start of maven migration, separating java
client and server code is too much of a refactor, and even introduces package change (like
ConfigException needs to be removed from QuorumPeerConfig.ConfigException as both client and
server related classes throws it. Moving QuorumPeerConfig would bring too much file in common.)

    
    Also, zookeeper-common, zookeeper-client and zookeeper-server would have similar packages,
sometimes tripling the package names.
    
    Dependency hierarchy wise server would depend on client, there's no way to make the two
depend only on common. 
    
    And I didn't even start looking at the tests. Most of them depend on ZooKeeper.java and
other "main" classes.
    
    My suggestion: just leave zookeeper-server, or just zookeeper. 
    
    An email has been sent to the dev list to start the discussion on this.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nkalmar/zookeeper ZOOKEEPER-3029

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/670.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #670
    
----
commit dae0114a829d3f33198c76bf732b35961d5c26b7
Author: Norbert Kalmar <nkalmar@...>
Date:   2018-10-15T13:51:52Z

    ZOOKEEPER-3029 - MAVEN MIGRATION - create pom for core modules

commit 9c0e82fe37f27910daaf20248b3253e2aacef129
Author: Norbert Kalmar <nkalmar@...>
Date:   2018-10-15T19:34:50Z

    common-build-works

commit 0ba918a53d8204bdb5bdf7d5967d3f3382ca4a70
Author: Norbert Kalmar <nkalmar@...>
Date:   2018-10-15T21:12:25Z

    client in progress

----


---

Mime
View raw message