zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mohammad Arshad (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-3181) ZOOKEEPER-2355 broke Curator TestingQuorumPeerMain
Date Fri, 26 Oct 2018 06:23:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-3181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664716#comment-16664716
] 

Mohammad Arshad commented on ZOOKEEPER-3181:
--------------------------------------------

Logically, for this issue change should be done only in curator, not in ZooKeeper. Problem
is there because the way ZooKeeper is used by curator.

I want to understand how to avoid this problem from zookeeper side. Shall I check before creating
new method whether same method is available or not in the downstream projects? I don’t think
this is logical thing.

Any thoughts on how to avoid this issue in future?? 

> ZOOKEEPER-2355 broke Curator TestingQuorumPeerMain
> --------------------------------------------------
>
>                 Key: ZOOKEEPER-3181
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3181
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.5.3, 3.4.11
>            Reporter: Akira Ajisaka
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> ZOOKEEPER-2355 added a getQuorumPeer method to QuorumPeerMain [https://github.com/apache/zookeeper/blob/release-3.5.3/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java#L194].
TestingQuorumPeerMain has an identically named method, which is now unintentionally overridding
the one in the base class.
> This is fixed by CURATOR-409, however, I'd like this to be fixed in ZooKeeper as well.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message