zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ivmaykov <...@git.apache.org>
Subject [GitHub] zookeeper pull request #669: ZOOKEEPER-3152: Port ZK netty stack to netty4
Date Fri, 19 Oct 2018 19:21:39 GMT
Github user ivmaykov commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/669#discussion_r226756052
  
    --- Diff: zookeeper-common/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
    @@ -267,7 +298,7 @@ private void sendPkt(Packet p) {
             p.createBB();
             updateLastSend();
             sentCount++;
    -        channel.write(ChannelBuffers.wrappedBuffer(p.bb));
    +        channel.writeAndFlush(Unpooled.wrappedBuffer(p.bb));
    --- End diff --
    
    Can you explain what the purpose of that would be? According to the documentation, voidPromise()
returns a promise that will never be notified of success or failure.


---

Mime
View raw message