zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nkalmar <...@git.apache.org>
Subject [GitHub] zookeeper pull request #670: DO_NOT_MERGE - MAVEN MIGRATION - Separation of ...
Date Tue, 16 Oct 2018 07:10:36 GMT
Github user nkalmar commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/670#discussion_r225420100
  
    --- Diff: zookeeper-common/pom.xml ---
    @@ -0,0 +1,123 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
    +<!--
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +-->
    +  <modelVersion>4.0.0</modelVersion>
    +  <parent>
    +    <groupId>org.apache.zookeeper</groupId>
    +    <artifactId>zookeeper</artifactId>
    +    <version>2.6.0-SNAPSHOT</version>
    +  </parent>
    +
    +  <artifactId>zookeeper-common</artifactId>
    +  <name>Apache ZooKeeper - Common</name>
    +  <description>ZooKeeper common</description>
    +
    +  <dependencies>
    +    <dependency>
    +      <groupId>org.apache.zookeeper</groupId>
    +      <artifactId>zookeeper-jute</artifactId>
    +      <version>2.6.0-SNAPSHOT</version>
    --- End diff --
    
    This is a strongly work in progress, and possibly it will never make it into the codebase.

    I created this PR to show that it is possibly not a good idea to seperate server and client
java code :(


---

Mime
View raw message