zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper pull request #649: ZOOKEEPER-2847: Cannot bind to client port when...
Date Mon, 01 Oct 2018 04:10:10 GMT
Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/649#discussion_r221492399
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java ---
    @@ -306,7 +308,7 @@ public String toString(){
                 }           
                 if (type == LearnerType.OBSERVER) sw.append(":observer");
                 else if (type == LearnerType.PARTICIPANT) sw.append(":participant");    
       
    -            if (clientAddr!=null){
    +            if (clientAddr!=null && !isClientAddrFromStatic){
    --- End diff --
    
    seems good to keep the old semantic, there are some test cases that might check this.
Though it should be ok to not to this too as toString is not on critical path of any functionality
as far as I know.


---

Mime
View raw message