From dev-return-73819-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Fri Sep 28 07:58:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id BE361180627 for ; Fri, 28 Sep 2018 07:58:04 +0200 (CEST) Received: (qmail 79833 invoked by uid 500); 28 Sep 2018 05:58:03 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 79822 invoked by uid 99); 28 Sep 2018 05:58:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Sep 2018 05:58:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 4981D1A2266 for ; Fri, 28 Sep 2018 05:58:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 4Ku9QUbEk2km for ; Fri, 28 Sep 2018 05:58:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 55EA15F254 for ; Fri, 28 Sep 2018 05:58:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 85638E02EB for ; Fri, 28 Sep 2018 05:58:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0CA5C23F99 for ; Fri, 28 Sep 2018 05:58:00 +0000 (UTC) Date: Fri, 28 Sep 2018 05:58:00 +0000 (UTC) From: "Fangmin Lv (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (ZOOKEEPER-3157) Improve FuzzySnapshotRelatedTest to avoid flaky due to issues like connection loss MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-3157?page=3Dcom.atla= ssian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fangmin Lv updated ZOOKEEPER-3157: ---------------------------------- Description:=20 [~hanm] noticed that the test might failure because of ConnectionLoss when = trying to getData, [here is=C2=A0an example|[https://builds.apache.org/job/= ZooKeepertrunk/198/testReport/junit/org.apache.zookeeper.server.quorum/Fuzz= ySnapshotRelatedTest/testPZxidUpdatedWhenLoadingSnapshot|https://builds.apa= che.org/job/ZooKeeper-trunk/198/testReport/junit/org.apache.zookeeper.serve= r.quorum/FuzzySnapshotRelatedTest/testPZxidUpdatedWhenLoadingSnapshot/]], w= e should catch this and retry to avoid flaky. Internally, we=C2=A0'fixed'=C2=A0flaky test by adding junit.RetryRule in ZK= TestCase, which is the base class for most of the tests. I'm not sure this = is the right way to go or not, since it's actually 'hiding' the flaky tests= , but this will help reducing the flaky tests a lot if we're not going to t= ackle it in the near time, and we can check the testing history to find out= which tests are flaky and deal with them separately. So let me know if=C2= =A0this seems to provide any benefit in short term, if it is I'll provide a= patch to do that. was: [~hanm] noticed that the test might failure because of ConnectionLoss when = trying to getData, [here is one failure run|[https://builds.apache.org/job/= ZooKeepertrunk/198/testReport/junit/org.apache.zookeeper.server.quorum/Fuzz= ySnapshotRelatedTest/testPZxidUpdatedWhenLoadingSnapshot/|https://builds.ap= ache.org/job/ZooKeeper-trunk/198/testReport/junit/org.apache.zookeeper.serv= er.quorum/FuzzySnapshotRelatedTest/testPZxidUpdatedWhenLoadingSnapshot/]], = we should catch this and retry to avoid flaky. Internally, we=C2=A0'fixed'=C2=A0flaky test by adding junit.RetryRule in ZK= TestCase, which is the base class for most of the tests. I'm not sure this = is the right way to go or not, since it's actually 'hiding' the flaky tests= , but this will help reducing the flaky tests a lot if we're not going to t= ackle it in the near time, and we can check the testing history to find out= which tests are flaky and deal with them separately. So let me know if=C2= =A0this seems to provide any benefit in short term, if it is I'll provide a= patch to do that. > Improve FuzzySnapshotRelatedTest to avoid flaky due to issues like connec= tion loss > -------------------------------------------------------------------------= --------- > > Key: ZOOKEEPER-3157 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3157 > Project: ZooKeeper > Issue Type: Test > Components: tests > Affects Versions: 3.6.0 > Reporter: Fangmin Lv > Assignee: Fangmin Lv > Priority: Minor > Fix For: 3.6.0 > > > [~hanm] noticed that the test might failure because of ConnectionLoss whe= n trying to getData, [here is=C2=A0an example|[https://builds.apache.org/jo= b/ZooKeepertrunk/198/testReport/junit/org.apache.zookeeper.server.quorum/Fu= zzySnapshotRelatedTest/testPZxidUpdatedWhenLoadingSnapshot|https://builds.a= pache.org/job/ZooKeeper-trunk/198/testReport/junit/org.apache.zookeeper.ser= ver.quorum/FuzzySnapshotRelatedTest/testPZxidUpdatedWhenLoadingSnapshot/]],= we should catch this and retry to avoid flaky. > Internally, we=C2=A0'fixed'=C2=A0flaky test by adding junit.RetryRule in = ZKTestCase, which is the base class for most of the tests. I'm not sure thi= s is the right way to go or not, since it's actually 'hiding' the flaky tes= ts, but this will help reducing the flaky tests a lot if we're not going to= tackle it in the near time, and we can check the testing history to find o= ut which tests are flaky and deal with them separately. So let me know if= =C2=A0this seems to provide any benefit in short term, if it is I'll provid= e a patch to do that. -- This message was sent by Atlassian JIRA (v7.6.3#76005)