From dev-return-73477-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Fri Sep 21 19:32:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 66BBF180656 for ; Fri, 21 Sep 2018 19:32:04 +0200 (CEST) Received: (qmail 92462 invoked by uid 500); 21 Sep 2018 17:32:03 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 92451 invoked by uid 99); 21 Sep 2018 17:32:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Sep 2018 17:32:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 008931819E0 for ; Fri, 21 Sep 2018 17:32:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.001 X-Spam-Level: X-Spam-Status: No, score=-109.001 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id J27LNYxkifat for ; Fri, 21 Sep 2018 17:32:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 903205F544 for ; Fri, 21 Sep 2018 17:32:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id AAD6FE2072 for ; Fri, 21 Sep 2018 17:32:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 316DA23FA5 for ; Fri, 21 Sep 2018 17:32:00 +0000 (UTC) Date: Fri, 21 Sep 2018 17:32:00 +0000 (UTC) From: "Ilya Maykov (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (ZOOKEEPER-3152) Port ZK netty stack to netty 4 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-3152?page=3Dcom.atlas= sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D= 16623921#comment-16623921 ]=20 Ilya Maykov edited comment on ZOOKEEPER-3152 at 9/21/18 5:31 PM: ----------------------------------------------------------------- I'm not sure how to split it, since I don't think you can't make different = parts (client, server) depend on different versions of Netty. Any suggestio= ns for a splitting strategy are welcome. The change is actually not that bi= g, the patch I have now is ~600 lines added and ~500 lines deleted with 11 = files changed. was (Author: ilyam): I'm not sure how to split it, since I don't think you can't make different = parts (client, server) depend on different version of Netty. Any suggestion= s are welcome. The change is actually not that big, the patch I have now is= ~600 lines added and ~500 lines deleted with 11 files changed. > Port ZK netty stack to netty 4 > ------------------------------ > > Key: ZOOKEEPER-3152 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3152 > Project: ZooKeeper > Issue Type: Improvement > Components: java client, server > Affects Versions: 3.6.0 > Reporter: Ilya Maykov > Priority: Minor > > Netty 3 is super old. Let's port ZK's netty stack to netty 4. I'm working= on a patch that I will put up=C2=A0as a pull request on github once we=C2= =A0finish testing it internally at Facebook, just getting the Jira ticket r= eady ahead of time. -- This message was sent by Atlassian JIRA (v7.6.3#76005)