From dev-return-73210-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Sat Sep 15 00:56:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 746B218067A for ; Sat, 15 Sep 2018 00:56:04 +0200 (CEST) Received: (qmail 40979 invoked by uid 500); 14 Sep 2018 22:56:03 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 40968 invoked by uid 99); 14 Sep 2018 22:56:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Sep 2018 22:56:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 0DD1918057E for ; Fri, 14 Sep 2018 22:56:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id t3PhUb3L6ces for ; Fri, 14 Sep 2018 22:56:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E64175F3EE for ; Fri, 14 Sep 2018 22:56:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 82FC6E111B for ; Fri, 14 Sep 2018 22:56:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1E6CE23FA0 for ; Fri, 14 Sep 2018 22:56:00 +0000 (UTC) Date: Fri, 14 Sep 2018 22:56:00 +0000 (UTC) From: "Hudson (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ZOOKEEPER-3144) Potential ephemeral nodes inconsistent due to global session inconsistent with fuzzy snapshot MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-3144?page=3Dcom.atlas= sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D= 16615483#comment-16615483 ]=20 Hudson commented on ZOOKEEPER-3144: ----------------------------------- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #191 (See [https://bui= lds.apache.org/job/ZooKeeper-trunk/191/]) ZOOKEEPER-3144: Fix potential ephemeral nodes inconsistent due to global (h= anm: rev b58791016424e662c816e2253de96f3771f5d301) * (edit) src/java/test/org/apache/zookeeper/server/quorum/FuzzySnapshotRela= tedTest.java * (edit) src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java > Potential ephemeral nodes inconsistent due to global session inconsistent= with fuzzy snapshot > -------------------------------------------------------------------------= -------------------- > > Key: ZOOKEEPER-3144 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3144 > Project: ZooKeeper > Issue Type: Bug > Components: server > Affects Versions: 3.5.4, 3.6.0, 3.4.13 > Reporter: Fangmin Lv > Assignee: Fangmin Lv > Priority: Critical > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Found this issue recently when checking another prod issue, the problem i= s that the current code will update lastProcessedZxid before it's actually = making change for the global sessions in the DataTree. > =C2=A0 > In case there is a snapshot taking in progress, and there is a small time= stall between set lastProcessedZxid and update the session in DataTree due= to reasons like thread context switch or GC, etc, then it's possible the l= astProcessedZxid is actually set to the future which doesn't include the gl= obal session change (add or remove). > =C2=A0 > When reload this snapshot and it's txns, it will replay txns from lastPro= cessedZxid + 1, so it won't create the global session anymore, which could = cause data inconsistent. > =C2=A0 > When global sessions are inconsistent, it might have ephemeral inconsiste= nt as well, since the leader will delete all the ephemerals locally if ther= e is no global sessions associated with it, and if someone=C2=A0have=C2=A0s= napshot sync with it then that server will not have that ephemeral as well,= but others will. It will also have global session renew issue for that pro= blematic session. > =C2=A0 > The same issue exist for the closeSession txn, we need=C2=A0to move these= global session update logic before processTxn, so the lastProcessedZxid wi= ll not miss the global session here. > =C2=A0 > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)