From dev-return-72748-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Wed Sep 5 12:17:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2F463180654 for ; Wed, 5 Sep 2018 12:17:03 +0200 (CEST) Received: (qmail 6905 invoked by uid 500); 5 Sep 2018 10:17:02 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 6893 invoked by uid 99); 5 Sep 2018 10:17:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Sep 2018 10:17:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id BF5E3182C6D for ; Wed, 5 Sep 2018 10:17:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id EQId1VX9YtRB for ; Wed, 5 Sep 2018 10:17:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id D2DD25F3EA for ; Wed, 5 Sep 2018 10:17:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 674EFE111B for ; Wed, 5 Sep 2018 10:17:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2537D26B57 for ; Wed, 5 Sep 2018 10:17:00 +0000 (UTC) Date: Wed, 5 Sep 2018 10:17:00 +0000 (UTC) From: "Andor Molnar (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ZOOKEEPER-2990) Implement probabilistic tracing MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-2990?page=3Dcom.atlas= sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D= 16604232#comment-16604232 ]=20 Andor Molnar commented on ZOOKEEPER-2990: ----------------------------------------- [~bkanivets] What are the target versions of this patch? I suggest 3.5 and 3.6 only, because it's a minor improvement. (should only = fix critical and security issues in 3.4) > Implement probabilistic tracing > ------------------------------- > > Key: ZOOKEEPER-2990 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2990 > Project: ZooKeeper > Issue Type: Improvement > Components: server > Reporter: Bogdan Kanivets > Assignee: Bogdan Kanivets > Priority: Minor > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > It would be nice to have an ability to do probabilistic tracing similar t= o Cassandra=C2=A0 [nodetool|https://docs.datastax.com/en/dse/5.1/dse-admin/= datastax_enterprise/tools/nodetool/toolsSetTraceProbability.html] > This will help debug=C2=A0issues in prod systems. > I'd like to contribute if everyone is ok with the feature. > My suggestion is to add an extra parameter to ZooTrace to handle it. Ques= tions: > * should it be one global param or per each ZooTrace mask? I'm thinking = per mask > * should it be a new 4lw or=C2=A0part of 'stmk'? Leaning towards new wor= d and refactoring param passing to words (stmk=C2=A0is a special case right= now). > * there are places in the code that use LOG.trace directly. That will ha= ve to change to ZooTrace > I can=C2=A0make some initial implementation for demo/review. > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)