From dev-return-73338-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Wed Sep 19 16:51:07 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E649F180621 for ; Wed, 19 Sep 2018 16:51:06 +0200 (CEST) Received: (qmail 54797 invoked by uid 500); 19 Sep 2018 14:51:03 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 54390 invoked by uid 99); 19 Sep 2018 14:51:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Sep 2018 14:51:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 7288F182F47 for ; Wed, 19 Sep 2018 14:51:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id WSdqMsXSGbzI for ; Wed, 19 Sep 2018 14:51:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 5C31560CD6 for ; Wed, 19 Sep 2018 14:51:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 03CEEE2072 for ; Wed, 19 Sep 2018 14:51:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 7948923FA9 for ; Wed, 19 Sep 2018 14:51:00 +0000 (UTC) Date: Wed, 19 Sep 2018 14:51:00 +0000 (UTC) From: "Hadoop QA (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ZOOKEEPER-2641) AvgRequestLatency metric improves to be more accurate MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16620709#comment-16620709 ] Hadoop QA commented on ZOOKEEPER-2641: -------------------------------------- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2198//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2198//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2198//console This message is automatically generated. > AvgRequestLatency metric improves to be more accurate > ----------------------------------------------------- > > Key: ZOOKEEPER-2641 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2641 > Project: ZooKeeper > Issue Type: Improvement > Affects Versions: 3.4.7, 3.4.9 > Reporter: Allen Chan > Assignee: maoling > Priority: Minor > Labels: pull-request-available > Time Spent: 1h 50m > Remaining Estimate: 0h > > I posted a thread on the mailing list about finding AvgRequestLatency metric to be 0 all the time. I believe this is a valuable metric because it is useful to baseline performance of ZK and know when something is going wrong. > Another user (Arshad Mohammad) wrote up these notes. I am not a developer so i do not have ability to patch this. Filing this so hopefully someone with developer abilities can add this improvement. > "I find two reason whys AvgRequestLatency is almost all the time 0 > 1) Ping requests are counted the most: > AvgRequestLatency is calculated as > AvgRequestLatency=totalLatency/count > Ping requests come very often and complete very fast, these request add > nothing to totalLatency but add one to count. > 2) Wrong data type is chosen to store AvgRequestLatency: > AvgRequestLatency is calculated and store as the long value instead of > double vlaue. > In my opinion ZooKeeper code should be modified to improve this metrics > i) Ping request should be ignored while recording the statistics or at > least should be configurable whether to ignore or not. If ping request is > not counted even other metrics will be more meaningful. > ii) AvgRequestLatency should be of double type" -- This message was sent by Atlassian JIRA (v7.6.3#76005)