From dev-return-73698-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Tue Sep 25 19:37:14 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3DF0118061A for ; Tue, 25 Sep 2018 19:37:14 +0200 (CEST) Received: (qmail 97628 invoked by uid 500); 25 Sep 2018 17:37:13 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 97616 invoked by uid 99); 25 Sep 2018 17:37:12 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Sep 2018 17:37:12 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 2595F1A1011 for ; Tue, 25 Sep 2018 17:37:12 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.889 X-Spam-Level: ** X-Spam-Status: No, score=2.889 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_REPLY=1, HTML_MESSAGE=2, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id IeIeAFkE8d4s for ; Tue, 25 Sep 2018 17:37:11 +0000 (UTC) Received: from mail-oi1-f174.google.com (mail-oi1-f174.google.com [209.85.167.174]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 9FC5C5F3CE for ; Tue, 25 Sep 2018 17:37:10 +0000 (UTC) Received: by mail-oi1-f174.google.com with SMTP id d63-v6so2211512oic.12 for ; Tue, 25 Sep 2018 10:37:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=oMAvYwch5p1FzQRFZZRGYBA5g17k9pquZg4ZtCLL8fs=; b=clA7xE4X6MwlPG3R0epy9sBlLzfITg5wi+GGzxmyNWUITYSEBlT1GIKO/1sYGj4m7G LR+mE1KR2m8SY175NVWkUC0mib0nQk3a9JSbCGhFkYqPhLSwfQ/v57u/T1gKwVgPsVOU M7sOWzgZkaE+8p4YpAsXkf+TjN7uxd43kOb28qg8mOqHsIAHBPqA0jlfr8kffDNndwOh cHpIQXqk1VSjXoR8yOyDWDhUr6iqXRWKABZFdMWRIC4pAlxr2bMA23eXrIdPstCA/yPy pGUHUFu0MfSKvvvPxw56dfBDMhHq+AJipt8etED1zGztL8MkNVFjfyMPDmbCZSGqNulE 2Ztw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=oMAvYwch5p1FzQRFZZRGYBA5g17k9pquZg4ZtCLL8fs=; b=gExhhFfKtvahGP/6bwRH9LNT4POcsy4nFv19nBFrusX8uT81/fTUJ4YKh6AhvGoi/z ZRsUpS30SPv9XZKSdvcZ2bqN9iUz2o8unXldjkgfKSB4yOKoWtsTKiJh2xQNUsFv4+dL MtDhPrUPS2Q1IVcUUUqPtXiQlHL/8+SLFFT4zstXGJzQ/NOdnsqDiUo98FLGjbxYOrW/ d+VnFOHluB/MB8pBxGWG2OHsoHfz7QDSkg6Nm4718xDskqVWWXcc58f6BTrMsifwthdr ypAmnrlFt3savNbOFw6vdMTJDh6q7XwhEL7KogHX0pr1AZlLqTXwJilh+ur1rjSIvlOW RV6g== X-Gm-Message-State: ABuFfojzfZG8ALKIGvwLgPP6u3JekbuxP3f8RdBRJowa41PZmAszkxw1 lSoXujvunXCw5oVTmzFGqoVQNHhvuMKczdhMBUEoRw== X-Google-Smtp-Source: ACcGV61i3pFsij8GFjbZCsGrErzkRDxUtL6+15qPbrNVjkeINfx5Vn1Ccl277ZCl0HLj1tSSbZBV4uRWqQmbQJNULuw= X-Received: by 2002:aca:ab0e:: with SMTP id u14-v6mr1312295oie.53.1537897029669; Tue, 25 Sep 2018 10:37:09 -0700 (PDT) MIME-Version: 1.0 References: <2ac40af0-4a9c-22ce-99b5-565bda14ff40@apache.org> In-Reply-To: <2ac40af0-4a9c-22ce-99b5-565bda14ff40@apache.org> From: Brian Nixon Date: Tue, 25 Sep 2018 10:36:01 -0700 Message-ID: Subject: Re: New precommit job 'retest this please' trick To: dev@zookeeper.apache.org Content-Type: multipart/alternative; boundary="0000000000002798020576b58e9a" --0000000000002798020576b58e9a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Excellent! On Mon, Sep 24, 2018 at 11:06 AM Andor Moln=C3=A1r wrote= : > Awesome! > > > > On 09/24/2018 06:27 PM, Michael Han wrote: > >>> How the new process any different from that? > > Jenkins job triggered by "Rebuild" button can't write back the job resu= lt > > to github, leading to a yellow pending check status even after the job > > finished; while "test this please" does not have this issue. > > > > > > On Mon, Sep 24, 2018 at 7:01 AM, Andor Molnar > > > wrote: > > > >> I usually logged in to Jenkins for other reasons, but that's also fine > to > >> have this option. > >> > >> Cheers > >> Andor > >> > >> > >> > >> On Mon, Sep 24, 2018 at 3:51 PM, Enrico Olivelli > >> wrote: > >> > >>> Il lun 24 set 2018, 15:25 Andor Molnar h= a > >>> scritto: > >>> > >>>> Thanks Enrico. Afaik the Rebuild button was already available for > >>>> committers. > >>>> How the new process any different from th > >>>> > >>> In order to relaunch tests you do not need to go to jenkins but simpl= y > >> add > >>> a 'retest this please' comment on the PR > >>> > >>> Much simpler IMO > >>> > >>> > >>> Enrico > >>> > >>> > >>>> Andor > >>>> > >>>> > >>>> On Sun, Sep 23, 2018 at 8:09 AM, Enrico Olivelli > > >>>> wrote: > >>>> > >>>>> Hi ZooKeepers, > >>>>> we have enhanced the "precommit" automated QA testing. > >>>>> Before merging any patch the committer should wait for a "green > >> light" > >>> on > >>>>> CI, > >>>>> but unfortunately we have a few flaky tests which are very annoying= . > >>>>> > >>>>> Now any Apache Committer, member of the 'apache' organization on > >>>>> github, is able to restart the QA job just by simply adding a singl= e > >>>>> line comment > >>>>> > >>>>> retest this please > >>>>> > >>>>> I will update the wiki accordingly > >>>>> https://cwiki.apache.org/confluence/display/ZOOKEEPER/ > >> HowToContribute > >>>>> The job on CI is > >>>>> https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/ > >>>>> > >>>>> Cheers > >>>>> Enrico > >>>>> > >>> -- > >>> > >>> > >>> -- Enrico Olivelli > >>> > > --0000000000002798020576b58e9a--