From dev-return-73457-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Fri Sep 21 14:45:29 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id B28A7180671 for ; Fri, 21 Sep 2018 14:45:28 +0200 (CEST) Received: (qmail 88111 invoked by uid 500); 21 Sep 2018 12:45:27 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 88083 invoked by uid 99); 21 Sep 2018 12:45:27 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Sep 2018 12:45:27 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id A21CAC0558 for ; Fri, 21 Sep 2018 12:45:26 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.888 X-Spam-Level: * X-Spam-Status: No, score=1.888 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id woEItGbMoAQr for ; Fri, 21 Sep 2018 12:45:24 +0000 (UTC) Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id BA76F5F2FF for ; Fri, 21 Sep 2018 12:45:23 +0000 (UTC) Received: by mail-wm1-f54.google.com with SMTP id f21-v6so2918466wmc.5 for ; Fri, 21 Sep 2018 05:45:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wD/F8aU1k6Wpoes079+iBsjYkjPWrTvfzG+ITgDy4xI=; b=hqHB9qF/J9JuyugtpYtn38rxPPe+yaQNAKL6qNPuMbkH3dZekikJV3F2jZbZouWdGw 4xqAbngIUlCzEUqRFNn001PBa9LUxIbh04Mt+727J5HjVl5QBPbW79D6xQYtAsupkxS8 qzG9NoWLvcFeX+UhA/Xu5o7mq/XAQaqPH9w0BMLU4yZak9I7ohePajs7md1OPZ1gX9Nw JlxHhBS2fMWS5HTZPtsL+lauAUJn4xPLWqZA7fzoA4gBCzLX/x6gPzJN/rOwrBgOxpJN Yjv1rufSbxoU2DyMz6Qta3noQGqc8MdPhnl+7dYzhcheAvamSVxXCuhFTQvAPIR+ayNq Dv/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wD/F8aU1k6Wpoes079+iBsjYkjPWrTvfzG+ITgDy4xI=; b=mm4LuxN0CKmgV6I3jHScfNHP1bsMxsT90z8GwwNsMlSMDlo+/F6/iVkxsiv8jphoEK e6CxTiKLJjus9W89gqEokIINC+pscB5dPBxkJlRb9zmn6I07hQ0zRiRt1OIB9TAQNCeu bwxCEFhU6G0WvR/6eaoXoqOFIfRcl8nlmiCCk8OsdqUqT0JMIbgplcYosKUvQbuLOuGG L/jbWFaO5vzhoCpau68szgpMQHPi3giiR1Tdn9nVApiSYWJ7XdWcZ1aFgJaLXSBtGgw8 OL7cKEd8xUiXJEX4r+uPXnWsyIVYnpHNr7Uq0sKCMXZ+b+zacjJTMd/PFD1YsaWHa5Xc 6AZg== X-Gm-Message-State: APzg51A9TjuAoWw9UgvEb5ZsYij6JI+cnWeFwjxnoYdYkuIQpW1wuLcd hHjfdBFWBZdqzsrn2Q8RCv/icT1Gi27IaLoeaj0= X-Google-Smtp-Source: ANB0Vda4oGTlCACqEwq7ibCIOdB23tWFElpFsvAqwJ8ctanJD1DAodjZCgqwJJhqNmmrVEDFZzqsjbS+bpP4b2gGRe4= X-Received: by 2002:a1c:6846:: with SMTP id d67-v6mr7009691wmc.125.1537533923068; Fri, 21 Sep 2018 05:45:23 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Enrico Olivelli Date: Fri, 21 Sep 2018 14:45:10 +0200 Message-ID: Subject: Re: About Jenkins pre-commit job To: Michael Han Cc: DevZooKeeper Content-Type: multipart/alternative; boundary="0000000000005091a605766103e5" --0000000000005091a605766103e5 Content-Type: text/plain; charset="UTF-8" Okay on github you see two lines, but there is only one job on Jenkins see https://github.com/apache/zookeeper/pull/638 @Michael Han please double check If all it is okay I will send a new clean summary in another email thread The short version is: - an user sends a PR (against master, branch-3.5 and branch-3.4)> CI kicks in an validates, on GitHub you see the status and the results - an "Apache Committer" (from any project I guess, as I am not a ZK committer but it works, it is important that he is registered in Apache Gihub 'organization') can add a comment with only this phrase 'retest this please' and the PR will be re-validated from CI - if the description of the PR contains 'skip ci' validation won't be run from jenkins configuration is here: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/ Please tell me if there is any doc/wiki to update and if there is a common place for storing CI Jobs configurations Enrico Il giorno ven 21 set 2018 alle ore 11:56 Enrico Olivelli < eolivelli@gmail.com> ha scritto: > > > Il giorno ven 21 set 2018 alle ore 11:27 Enrico Olivelli < > eolivelli@gmail.com> ha scritto: > >> I have set up the 'retest this please' trigger. >> But now we have two jobs running for each pull request. >> >> I can't find the flag which makes the validation named 'Jenkins' start >> >> https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/configure >> >> the name of the new one is 'default', and it maps to the same Job >> > > Actually the result for the new 'default' validation looks better > see it here > https://github.com/apache/zookeeper/pull/637 > > The old one just told 'Looks like there's a problem with this pull request' > the new one reports ' FAILURE 1731 tests run, 1 skipped, 2 failed' > > Enrico > > > >> is there any other trigger ? >> I will continue to search >> >> Enrico >> >> Il giorno ven 21 set 2018 alle ore 09:33 Enrico Olivelli < >> eolivelli@gmail.com> ha scritto: >> >>> I apologize if there will be some spam on the list >>> >>> When you enable this trigger asfgit starts to add comments like this: >>> Can one of the admins verify this patch? >>> >>> I am looking for a solution. We had the same on BookKeeper jobs >>> >>> Enrico >>> >>> Il giorno ven 21 set 2018 alle ore 09:31 Enrico Olivelli < >>> eolivelli@gmail.com> ha scritto: >>> >>>> >>>> >>>> Il giorno ven 21 set 2018 alle ore 03:44 Michael Han >>>> ha scritto: >>>> >>>>> Thanks Enrico for volunteering, it'll be cool if we can fix this. >>>>> >>>> >>>> Ok, working now on >>>> https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/ >>>> >>>> Stay tuned >>>> Enrico >>>> >>>> >>>>> >>>>> On Wed, Sep 19, 2018 at 10:42 PM, Enrico Olivelli >>>> > wrote: >>>>> >>>>>> Il gio 20 set 2018, 01:17 Michael Han ha scritto: >>>>>> >>>>>> > We've seen lots of confusions recently around Jenkins pre-commit >>>>>> check >>>>>> > status on github pull request as well as questions like how to >>>>>> trigger >>>>>> > Jenkins job to get a green build. I added a section "Jenkins >>>>>> Pre-commit >>>>>> > Check" to our wiki page about this matter: >>>>>> > >>>>>> > >>>>>> https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute >>>>>> > >>>>>> > I suspect the permission issue is about the fact that apache >>>>>> zookeeper >>>>>> > github is read only for most of us including committers. Only >>>>>> asfbot has >>>>>> > write access. When a Jenkins job is triggered through "Rebuild" >>>>>> button the >>>>>> > credential it's using is not asfbot thus the final job result will >>>>>> fail to >>>>>> > write back to github. I don't know how to solve this, but hopefully >>>>>> we have >>>>>> > workarounds (which though require PR creator to be more diligent on >>>>>> > obtaining a green build). >>>>>> > >>>>>> >>>>>> In Bookkeeper we have enabled the magic 'retest this please' and it >>>>>> is very >>>>>> useful. >>>>>> >>>>>> I can take a look in order to back port to ZK, I have access to ASF >>>>>> Jenkins >>>>>> so I can check current configuration for ZK. >>>>>> >>>>>> In Bookkeeper we also have the configuration of Jenkins jobs on git, >>>>>> using >>>>>> Jenkins DSL language. I can also take a look and see how to port to ZK >>>>>> >>>>>> >>>>>> >>>>>> Enrico >>>>>> >>>>>> >>>>>> > Michael. >>>>>> > >>>>>> -- >>>>>> >>>>>> >>>>>> -- Enrico Olivelli >>>>>> >>>>> >>>>> --0000000000005091a605766103e5--