From dev-return-73905-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Sat Sep 29 17:08:39 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8FE21180672 for ; Sat, 29 Sep 2018 17:08:38 +0200 (CEST) Received: (qmail 54222 invoked by uid 500); 29 Sep 2018 15:08:37 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 54211 invoked by uid 99); 29 Sep 2018 15:08:36 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 29 Sep 2018 15:08:36 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 75DF8DFFAC; Sat, 29 Sep 2018 15:08:36 +0000 (UTC) From: tamaashu To: dev@zookeeper.apache.org Reply-To: dev@zookeeper.apache.org References: In-Reply-To: Subject: [GitHub] zookeeper pull request #650: ZOOKEEPER-1908: setAcl should be have a recursi... Content-Type: text/plain Message-Id: <20180929150836.75DF8DFFAC@git1-us-west.apache.org> Date: Sat, 29 Sep 2018 15:08:36 +0000 (UTC) Github user tamaashu commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/650#discussion_r221430894 --- Diff: src/java/main/org/apache/zookeeper/cli/SetAclCommand.java --- @@ -35,10 +37,11 @@ { options.addOption("s", false, "stats"); options.addOption("v", true, "version"); + options.addOption("R", false, "recursive"); } public SetAclCommand() { - super("setAcl", "[-s] [-v version] path acl"); + super("setAcl", "[-s] [-v version] [-R] path acl"); } --- End diff -- Since we don't have it for [-s] either, I think it's more consistent to keep [-R]. ---