From dev-return-73261-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org  Sun Sep 16 13:39:45 2018
Return-Path: <dev-return-73261-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 42EBA180652
	for <archive-asf-public@cust-asf.ponee.io>; Sun, 16 Sep 2018 13:39:45 +0200 (CEST)
Received: (qmail 23909 invoked by uid 500); 16 Sep 2018 11:39:44 -0000
Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@zookeeper.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@zookeeper.apache.org>
List-Post: <mailto:dev@zookeeper.apache.org>
List-Id: <dev.zookeeper.apache.org>
Reply-To: dev@zookeeper.apache.org
Delivered-To: mailing list dev@zookeeper.apache.org
Received: (qmail 23887 invoked by uid 99); 16 Sep 2018 11:39:43 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 16 Sep 2018 11:39:43 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 437F9E0A9F; Sun, 16 Sep 2018 11:39:43 +0000 (UTC)
From: eolivelli <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-629-zookeeper@git.apache.org>
In-Reply-To: <git-pr-629-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #629: ZOOKEEPER-2641:AvgRequestLatency metric improve...
Content-Type: text/plain
Message-Id: <20180916113943.437F9E0A9F@git1-us-west.apache.org>
Date: Sun, 16 Sep 2018 11:39:43 +0000 (UTC)

Github user eolivelli commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/629#discussion_r217911197
  
    --- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java ---
    @@ -54,9 +57,10 @@ synchronized public long getMinLatency() {
             return minLatency == Long.MAX_VALUE ? 0 : minLatency;
         }
     
    -    synchronized public long getAvgLatency() {
    +    synchronized public double getAvgLatency() {
             if (count != 0) {
    -            return totalLatency / count;
    +            String avgLatency = df.format((double)totalLatency / count);
    +            return Double.parseDouble(avgLatency);
    --- End diff --
    
    Why don't you this way ?
    return totalLatency *1.0 / count
    
    Using format/parse is costly and it can lead to unexpected results, expecially with floating point values


---