From dev-return-73152-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org  Fri Sep 14 14:04:56 2018
Return-Path: <dev-return-73152-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 8F0E4180647
	for <archive-asf-public@cust-asf.ponee.io>; Fri, 14 Sep 2018 14:04:55 +0200 (CEST)
Received: (qmail 75048 invoked by uid 500); 14 Sep 2018 12:04:54 -0000
Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@zookeeper.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@zookeeper.apache.org>
List-Post: <mailto:dev@zookeeper.apache.org>
List-Id: <dev.zookeeper.apache.org>
Reply-To: dev@zookeeper.apache.org
Delivered-To: mailing list dev@zookeeper.apache.org
Received: (qmail 75037 invoked by uid 99); 14 Sep 2018 12:04:53 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Sep 2018 12:04:53 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id CE2B6DFC4A; Fri, 14 Sep 2018 12:04:53 +0000 (UTC)
From: eolivelli <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-622-zookeeper@git.apache.org>
In-Reply-To: <git-pr-622-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #622: [ZOOKEEPER-3145] Fix potential watch missing is...
Content-Type: text/plain
Message-Id: <20180914120453.CE2B6DFC4A@git1-us-west.apache.org>
Date: Fri, 14 Sep 2018 12:04:53 +0000 (UTC)

Github user eolivelli commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/622#discussion_r217689682
  
    --- Diff: src/java/test/org/apache/zookeeper/server/quorum/FuzzySnapshotRelatedTest.java ---
    @@ -60,14 +60,17 @@
     
         MainThread[] mt = null;
         ZooKeeper[] zk = null;
    +    int[] clientPorts = null;
         int leaderId;
         int followerA;
     
         @Before
         public void setup() throws Exception {
    +        ZooKeeperServer.setCloseSessionTxnEnabled(true);
    --- End diff --
    
    This property won't impact other testcases in the class. Okay


---