zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maoling <...@git.apache.org>
Subject [GitHub] zookeeper pull request #629: ZOOKEEPER-2641:AvgRequestLatency metric improve...
Date Sun, 16 Sep 2018 11:19:41 GMT
GitHub user maoling opened a pull request:

    https://github.com/apache/zookeeper/pull/629

    ZOOKEEPER-2641:AvgRequestLatency metric improves to be more accurate

    - Since 4lw will be deprecated,so this patch only for branch3.4
    - ZOOKEEPER-3074 is not applied to branch3.4 and Jenkins complains about [it](https://builds.apache.org/job/ZooKeeper_branch34_java10/152/testReport/junit/org.apache.zookeeper.server/ServerStatsTest/testLatencyMetrics/),
I fix it without extra trouble
    - still leave a work undo for discussion,what should we deal with `Ping` request?
     >Ping request should be ignored while recording the statistics or at
    least should be configurable whether to ignore or not. If ping request is
    not counted even other metrics will be more meaningful. 
    - more details in [ZOOKEEPER-2641](https://issues.apache.org/jira/browse/ZOOKEEPER-2641)

      

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/maoling/zookeeper branch-3.4-ZOOKEEPER-2641

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/629.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #629
    
----
commit 8611bc4eb35353b2e6ed82d21759b3f3353c564d
Author: maoling <maoling199210191@...>
Date:   2018-09-16T11:05:21Z

    ZOOKEEPER-2641:AvgRequestLatency metric improves to be more accurate

----


---

Mime
View raw message