zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Han (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-3157) Improve FuzzySnapshotRelatedTest to avoid flaky due to issues like connection loss
Date Fri, 28 Sep 2018 17:09:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-3157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16632139#comment-16632139
] 

Michael Han commented on ZOOKEEPER-3157:
----------------------------------------

[~lvfangmin] thanks for making a fix on this.

For this specific flaky test, we could either do what I suggested there (by wrapping the getData
with some retry logic), or apply junit.RetryRule for this specific test case only since we
know the cause and the fix should be retry anyway. I suggest we should not add junit.RetryRule
to all test cases / ZKTestCase for reasons I mentioned here https://github.com/apache/zookeeper/pull/605#issuecomment-425496416.

> Improve FuzzySnapshotRelatedTest to avoid flaky due to issues like connection loss
> ----------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-3157
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3157
>             Project: ZooKeeper
>          Issue Type: Test
>          Components: tests
>    Affects Versions: 3.6.0
>            Reporter: Fangmin Lv
>            Assignee: Fangmin Lv
>            Priority: Minor
>             Fix For: 3.6.0
>
>
> [~hanm] noticed that the test might failure because of ConnectionLoss when trying to
getData, [here is an example|https://builds.apache.org/job/ZooKeepertrunk/198/testReport/junit/org.apache.zookeeper.server.quorum/FuzzySnapshotRelatedTest/testPZxidUpdatedWhenLoadingSnapshot],
we should catch this and retry to avoid flaky.
> Internally, we 'fixed' flaky test by adding junit.RetryRule in ZKTestCase, which is
the base class for most of the tests. I'm not sure this is the right way to go or not, since
it's actually 'hiding' the flaky tests, but this will help reducing the flaky tests a lot
if we're not going to tackle it in the near time, and we can check the testing history to
find out which tests are flaky and deal with them separately. So let me know if this seems
to provide any benefit in short term, if it is I'll provide a patch to do that.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message