zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bogdan Kanivets (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2990) Implement probabilistic tracing
Date Wed, 12 Sep 2018 05:00:04 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611596#comment-16611596
] 

Bogdan Kanivets commented on ZOOKEEPER-2990:
--------------------------------------------

[~andorm] Sounds good. I'll do the PR for 3.5/3.6. I agree that new features should be in
3.5, but at the same time this is more of an 'operations' improvement. If there are more user
requests for this one, maybe we can consider 3.4 later.

> Implement probabilistic tracing
> -------------------------------
>
>                 Key: ZOOKEEPER-2990
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2990
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server
>            Reporter: Bogdan Kanivets
>            Assignee: Bogdan Kanivets
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> It would be nice to have an ability to do probabilistic tracing similar to Cassandra 
[nodetool|https://docs.datastax.com/en/dse/5.1/dse-admin/datastax_enterprise/tools/nodetool/toolsSetTraceProbability.html]
> This will help debug issues in prod systems.
> I'd like to contribute if everyone is ok with the feature.
> My suggestion is to add an extra parameter to ZooTrace to handle it. Questions:
>  * should it be one global param or per each ZooTrace mask? I'm thinking per mask
>  * should it be a new 4lw or part of 'stmk'? Leaning towards new word and refactoring
param passing to words (stmk is a special case right now).
>  * there are places in the code that use LOG.trace directly. That will have to change
to ZooTrace
> I can make some initial implementation for demo/review.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message