zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lvfangmin <...@git.apache.org>
Subject [GitHub] zookeeper pull request #649: ZOOKEEPER-2847: Cannot bind to client port when...
Date Sun, 30 Sep 2018 20:33:44 GMT
Github user lvfangmin commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/649#discussion_r221472398
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java ---
    @@ -306,7 +308,7 @@ public String toString(){
                 }           
                 if (type == LearnerType.OBSERVER) sw.append(":observer");
                 else if (type == LearnerType.PARTICIPANT) sw.append(":participant");    
       
    -            if (clientAddr!=null){
    +            if (clientAddr!=null && !isClientAddrFromStatic){
    --- End diff --
    
    Not sure we should do this or not, others LGTM.


---

Mime
View raw message