zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ivmaykov <...@git.apache.org>
Subject [GitHub] zookeeper pull request #184: ZOOKEEPER-236: SSL Support for Atomic Broadcast...
Date Fri, 28 Sep 2018 20:15:52 GMT
Github user ivmaykov commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/184#discussion_r221369391
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java ---
    @@ -303,6 +305,10 @@ public void parseProperties(Properties zkProp)
                     } else {
                         throw new ConfigException("Invalid option " + value + " for reconfigEnabled
flag. Choose 'true' or 'false.'");
                     }
    +            } else if (key.equals("sslQuorum")){
    +                sslQuorum = Boolean.parseBoolean(value);
    +            } else if (key.equals("portUnification")){
    +                shouldUsePortUnification = Boolean.parseBoolean(value);
    --- End diff --
    
    I agree with @hanm - comment out these two lines, and add a comment:
    
    `// TODO: UnifiedServerSocket is currently buggy, will be fixed when @ivmaykov's PRs are
merged. Disable port unification until then.`


---

Mime
View raw message