zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper pull request #184: ZOOKEEPER-236: SSL Support for Atomic Broadcast...
Date Fri, 28 Sep 2018 00:03:24 GMT
Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/184#discussion_r221104823
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java ---
    @@ -303,6 +305,10 @@ public void parseProperties(Properties zkProp)
                     } else {
                         throw new ConfigException("Invalid option " + value + " for reconfigEnabled
flag. Choose 'true' or 'false.'");
                     }
    +            } else if (key.equals("sslQuorum")){
    +                sslQuorum = Boolean.parseBoolean(value);
    +            } else if (key.equals("portUnification")){
    +                shouldUsePortUnification = Boolean.parseBoolean(value);
    --- End diff --
    
    i think we need to disable the parsing code here for this patch, right?


---

Mime
View raw message