zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper pull request #184: ZOOKEEPER-236: SSL Support for Atomic Broadcast...
Date Fri, 28 Sep 2018 00:03:24 GMT
Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/184#discussion_r221069516
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
    @@ -534,14 +543,12 @@ private void handleConnection(Socket sock, DataInputStream din)
                     LOG.info("Setting arbitrary identifier to observer: " + sid);
                 }
             } catch (IOException e) {
    +            LOG.warn("Exception reading or writing challenge: {}", e);
                 closeSocket(sock);
    -            LOG.warn("Exception reading or writing challenge: {}", e.toString());
                 return;
             }
    -
    --- End diff --
    
    nit: keep this empty line.


---

Mime
View raw message