zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anmolnar <...@git.apache.org>
Subject [GitHub] zookeeper pull request #639: ZOOKEEPER-2122: add openssl to zookeeper c clie...
Date Tue, 25 Sep 2018 10:21:35 GMT
Github user anmolnar commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/639#discussion_r220134951
  
    --- Diff: zookeeper-client/zookeeper-client-c/CMakeLists.txt ---
    @@ -56,7 +56,7 @@ option(WANT_CPPUNIT "Enables CppUnit and tests" ${DEFAULT_WANT_CPPUNIT})
     # SOCK_CLOEXEC
     option(WANT_SOCK_CLOEXEC "Enables SOCK_CLOEXEC on sockets" OFF)
     include(CheckSymbolExists)
    -check_symbol_exists(SOCK_CLOEXEC sys/socket.h HAVE_SOCK_CLOEXEC)
    +check_symbol_exists(zktest_runnerSOCK_CLOEXEC sys/socket.h HAVE_SOCK_CLOEXEC)
    --- End diff --
    
    Didn't you miss a whitespace here like `zktest_runner SOCK_CLOEXEC`?


---

Mime
View raw message