zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper pull request #590: [ZOOKEEPER-1177] Add the memory optimized watch...
Date Sat, 22 Sep 2018 04:38:34 GMT
Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/590#discussion_r219640916
  
    --- Diff: src/java/main/org/apache/zookeeper/server/DataTree.java ---
    @@ -253,6 +259,14 @@ public DataTree() {
             addConfigNode();
     
             nodeDataSize.set(approximateDataSize());
    +        try {
    +            dataWatches = WatchManagerFactory.createWatchManager();
    +            childWatches = WatchManagerFactory.createWatchManager();
    +        } catch (Exception e) {
    +            LOG.error("Unexpected exception when creating WatchManager, " +
    +                    "exiting abnormally", e);
    --- End diff --
    
    nit: use parameterized logging here.


---

Mime
View raw message