zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper pull request #590: [ZOOKEEPER-1177] Add the memory optimized watch...
Date Sat, 22 Sep 2018 04:38:34 GMT
Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/590#discussion_r219644285
  
    --- Diff: src/java/main/org/apache/zookeeper/server/watch/WatchManager.java ---
    @@ -180,7 +192,8 @@ synchronized void dumpWatches(PrintWriter pwriter, boolean byPath)
{
          *            watcher object reference
          * @return true if the watcher exists, false otherwise
          */
    --- End diff --
    
    we should remove this comment, which is already present in the `IWatchManager`, also for
consistency with other overrides in `WatchManager`.


---

Mime
View raw message