zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lvfangmin <...@git.apache.org>
Subject [GitHub] zookeeper pull request #629: ZOOKEEPER-2641:AvgRequestLatency metric improve...
Date Wed, 19 Sep 2018 06:02:31 GMT
Github user lvfangmin commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/629#discussion_r218676806
  
    --- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java ---
    @@ -819,7 +819,7 @@ public void commandRun() {
                 }
             }
     
    -        private void print(String key, long number) {
    +        private void print(String key, Object number) {
    --- End diff --
    
    It's better to override print with double number, which will be more efficient, as we
don't need to cast all the numbers to Object while printing the metrics.


---

Mime
View raw message