zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper issue #184: ZOOKEEPER-236: SSL Support for Atomic Broadcast protoc...
Date Mon, 17 Sep 2018 23:35:18 GMT
Github user hanm commented on the issue:

    https://github.com/apache/zookeeper/pull/184
  
    I like @anmolnar plan. 
    
    To mitigate the stability concerns around `UnifiedServerSocket`, we can disable it by
default. Unless I misunderstand something, when unified port is disabled via `portUnification=false`,
there should not be any DOS or stability issues observed during your tests, is this correct?
@ivmaykov 
    
    Regarding remove port unification / unified server socket from this PR, that's definitely
another approach, but consider we need add it anyway plus we have mitigations in place this
would just create more work.
    
    Regarding concerns of the final release with this PR committed but not any of the #627
, I think it's a fair concern, but given we have the mitigation in place I think we can release
in worst case (that this PR goes in but none of #627 ) - though realistically I am optimistic
that we can get most if not all of the #627 in before stable 3.5 release.


---

Mime
View raw message