zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ivmaykov <...@git.apache.org>
Subject [GitHub] zookeeper issue #184: ZOOKEEPER-236: SSL Support for Atomic Broadcast protoc...
Date Mon, 17 Sep 2018 04:27:43 GMT
Github user ivmaykov commented on the issue:

    @anmolnar what are the chances do you think of getting both PRs into the 3.5 release?
I think if we only get in #184 and not #627, that would be a big problem, since #184 has stability
issues in UnifiedServerSocket - I would say it's not safe to use in production with `portUnification
= true`. If we can get both PRs into the 3.5 release, let's go ahead with merging #184 and
then work on getting #627 merged. However, if there is a significant risk of not merging in
#627, then I feel like we should at least backport the fixes to `UnifiedServerSocket` and
`PrependableSocket` from that PR into this one. It would be nice to backport the changes to
UnifiedServerSocket test, but unfortunately they depend on a bunch of other stuff that would
make it hard to do cleanly.


View raw message