zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper issue #580: ZOOKEEPER-3098: Add additional server metrics
Date Fri, 14 Sep 2018 22:37:38 GMT
Github user hanm commented on the issue:

    https://github.com/apache/zookeeper/pull/580
  
    From the conversation so far, it looks like we have reached a consensus regarding the
directions of this patch and future metrics related patch. For this specific patch, it looks
good to me, and I only have one comment regarding FOLLOWER_SYNC_TIME instrumentation but that's
not blocking.
    
    Any comments from other reviewers? @anmolnar @eolivelli @lvfangmin 
    Let's try to get this patch merge in soon to avoid constant turnovers on merge conflicts
(unfortunately, it got another merge conflicts that requires another rebase.).


---

Mime
View raw message