zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lvfangmin <...@git.apache.org>
Subject [GitHub] zookeeper pull request #622: [ZOOKEEPER-3145] Fix potential watch missing is...
Date Fri, 14 Sep 2018 16:30:29 GMT
Github user lvfangmin commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/622#discussion_r217770370
  
    --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java ---
    @@ -1861,6 +1862,76 @@ public void testFaultyMetricsProviderOnConfigure() throws Exception
{
             Assert.assertTrue("complains about metrics provider MetricsProviderLifeCycleException",
found);
         }
     
    +    /**
    +     * Test leader/leader compatibility with/without CloseSessionTxn, so that
    +     * we can gradually rollout this code and rollback if there is problem.
    +     */
    +    @Test
    +    public void testCloseSessionTxnCompatile() throws Exception {
    --- End diff --
    
    It's not a good practice to add parameter in the test class if only a single test is using
it, have a test helper function like this seems better to me.


---

Mime
View raw message