zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper pull request #623: [ZOOKEEPER-3146] Limit the maximum client conne...
Date Fri, 14 Sep 2018 02:19:15 GMT
Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/623#discussion_r217585326
  
    --- Diff: src/java/test/org/apache/zookeeper/test/ClientTest.java ---
    @@ -506,7 +506,7 @@ private void performClientTest(boolean withWatcherObj)
                 }
    --- End diff --
    
    Thanks @lvfangmin, best effort is good enough, we can tolerate some white space change
to avoid you have to port a patch line by line. As long as we are aware of the whitespace
only change issue and try to avoid it, we will be good. 


---

Mime
View raw message