zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From eolivelli <...@git.apache.org>
Subject [GitHub] zookeeper pull request #622: [ZOOKEEPER-3145] Fix potential watch missing is...
Date Thu, 13 Sep 2018 22:00:55 GMT
Github user eolivelli commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/622#discussion_r217546649
  
    --- Diff: src/java/test/org/apache/zookeeper/server/quorum/FuzzySnapshotRelatedTest.java
---
    @@ -60,14 +60,17 @@
     
         MainThread[] mt = null;
         ZooKeeper[] zk = null;
    +    int[] clientPorts = null;
         int leaderId;
         int followerA;
     
         @Before
         public void setup() throws Exception {
    +        ZooKeeperServer.setCloseSessionTxnEnabled(true);
    --- End diff --
    
    This test class will always be executed with this new option. It is an existing class,
are we losing some coverage ?


---

Mime
View raw message