zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lvfangmin <...@git.apache.org>
Subject [GitHub] zookeeper pull request #623: [ZOOKEEPER-3146] Limit the maximum client conne...
Date Thu, 13 Sep 2018 16:26:55 GMT
Github user lvfangmin commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/623#discussion_r217450443
  
    --- Diff: src/java/test/org/apache/zookeeper/test/ClientTest.java ---
    @@ -506,7 +506,7 @@ private void performClientTest(boolean withWatcherObj)
                 }
    --- End diff --
    
    Yes, it's formatted when I was checking this test manually on my MAC (was trying to see
where should  I add the unit test), I'll disable the auto-formatting on my MAC.
    
    The internal patches we did also have the white spaces formatted, we need to manually
port the code line by line in some cases if we want to totally avoid the white spaces, I'll
try my best, but I won't guarantee there is zero white space formatting.


---

Mime
View raw message