zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lvfangmin <...@git.apache.org>
Subject [GitHub] zookeeper issue #590: [ZOOKEEPER-1177] Add the memory optimized watch manage...
Date Wed, 12 Sep 2018 17:43:15 GMT
Github user lvfangmin commented on the issue:

    https://github.com/apache/zookeeper/pull/590
  
    Update based on the comments:
    
    1. add findbugs exclusion
    2. add comments for the newly added classes
    3. add admin doc for the new JVM options introduced in this diff
    4. move the bench project to src/test/java/bench
    5. move DumbWatcher to src/java/main dir for share between unit test and bench
    6. change to use ExitCode
    
    @nkalmar I moved the bench to src/test/java/bench, which seems more reasonable to me,
let me know if you think that's not a good position based on your plan.


---

Mime
View raw message