zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anmolnar <...@git.apache.org>
Subject [GitHub] zookeeper pull request #601: ZOOKEEPER-3123 MetricsProvider Lifecycle in Zoo...
Date Tue, 11 Sep 2018 12:45:07 GMT
Github user anmolnar commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/601#discussion_r216653165
  
    --- Diff: src/java/test/org/apache/zookeeper/metrics/BaseTestMetricsProvider.java ---
    @@ -0,0 +1,137 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.zookeeper.metrics;
    +
    +import java.util.Properties;
    +import java.util.concurrent.atomic.AtomicBoolean;
    +import java.util.concurrent.atomic.AtomicInteger;
    +import org.apache.zookeeper.metrics.impl.NullMetricsProvider;
    +
    +/**
    + * Simple MetricsProvider for tests.
    + */
    +public abstract class BaseTestMetricsProvider implements MetricsProvider {
    +
    +    @Override
    +    public void configure(Properties prprts) throws MetricsProviderLifeCycleException
{
    +    }
    +
    +    @Override
    +    public void start() throws MetricsProviderLifeCycleException {
    +    }
    +
    +    @Override
    +    public MetricsContext getRootContext() {
    +        return NullMetricsProvider.NullMetricsContext.INSTANCE;
    +    }
    +
    +    @Override
    +    public void stop() {
    +    }
    +
    +    public static final class MetricsProviderCapturingLifecycle extends BaseTestMetricsProvider
{
    +
    +        public static final AtomicBoolean configureCalled = new AtomicBoolean();
    --- End diff --
    
    This kind of stuff (tracking calls) is exactly the thing that can be nicely achieved with
Mockito mocks and/or spies in unit tests.
    
    https://www.baeldung.com/mockito-verify
    
    Would you please consider replace these test classes with mocks?



---

Mime
View raw message