zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper issue #580: ZOOKEEPER-3098: Add additional server metrics
Date Sat, 08 Sep 2018 05:25:09 GMT
Github user hanm commented on the issue:

    https://github.com/apache/zookeeper/pull/580
  
    Thanks for detailed reply, @jtuple.
    
    Jenkins was not happy because one C client test failed (the 'Test Result' only shows Java
tests). I kicked a 
    [new build](https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2141/),
and it passes.
    
    >> Other types like a Gauge could easily be done in a future pull-request, although
our experience has been that gauge's are less useful in a polling based approach since you
only see the most recent value. 
    
    OK.
    
    >> Once we land the set-variants, you could add a single metric to the ServerMetric
enum and rely upon the set logic.
    
    I think this is what I was looking for - a way of organizing metrics hierarchically like
files/folder or namespaces. Good to know it's already supported and will be upstreamed.


---

Mime
View raw message