zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From timothyjward <...@git.apache.org>
Subject [GitHub] zookeeper issue #530: [ZOOKEEPER-2474] Support session reconnection when usi...
Date Thu, 06 Sep 2018 08:54:29 GMT
Github user timothyjward commented on the issue:

    https://github.com/apache/zookeeper/pull/530
  
    I'm still not sure what additional testing is possible. The way the patch is constructed
the changed code (all three lines of it) is already exercised by the existing ZooKeeper tests.
The new constructors all delegate to existing constructors, so I'm not sure how to create
a "different" test rather than just duplicating another test, which seems like a poor practice
to me.


---

Mime
View raw message