zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maoling <...@git.apache.org>
Subject [GitHub] zookeeper pull request #593: [ZOOKEEPER-3111] Add socket buffer size option ...
Date Sat, 01 Sep 2018 08:09:03 GMT
Github user maoling commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/593#discussion_r214507592
  
    --- Diff: src/java/test/org/apache/zookeeper/server/SocketUtilTest.java ---
    @@ -37,7 +37,7 @@ public void testSetSocketBufferSize() throws Exception {
             Assert.assertEquals(initReceiveBufferSize, s.getReceiveBufferSize());
     
             // set NETWORK_BUFFER_SIZE
    -        int networkBufferSize = 1024 * 1024;
    +        int networkBufferSize = 32 * 1024;
             SocketUtil.setNetworkBufferSize(networkBufferSize);
             SocketUtil.setSocketBufferSize("test", s);
    --- End diff --
    
    Although it passed the test,but When do regression,it will also be a flaky(you can see
it by hitting it again and again).
    could you plz look at it?


---

Mime
View raw message