From dev-return-72590-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Tue Aug 28 08:15:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C59FC180621 for ; Tue, 28 Aug 2018 08:15:05 +0200 (CEST) Received: (qmail 1506 invoked by uid 500); 28 Aug 2018 06:15:04 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 1495 invoked by uid 99); 28 Aug 2018 06:15:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Aug 2018 06:15:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 541A4180871 for ; Tue, 28 Aug 2018 06:15:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id WpEtva6creGH for ; Tue, 28 Aug 2018 06:15:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 633C75F29A for ; Tue, 28 Aug 2018 06:15:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 19E62E00E1 for ; Tue, 28 Aug 2018 06:15:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6150026B59 for ; Tue, 28 Aug 2018 06:15:00 +0000 (UTC) Date: Tue, 28 Aug 2018 06:15:00 +0000 (UTC) From: "Michael Han (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ZOOKEEPER-3129) Improve ZK Client resiliency by throwing a jute.maxbuffer size exception before sending a request to server MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-3129?page=3Dcom.atlas= sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D= 16594570#comment-16594570 ]=20 Michael Han commented on ZOOKEEPER-3129: ---------------------------------------- We already have jute.maxbuffer property for client side (and server side). = Would this property fit the needs here? > Improve ZK Client resiliency by throwing a jute.maxbuffer size exception = before sending a request to server > -------------------------------------------------------------------------= ---------------------------------- > > Key: ZOOKEEPER-3129 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3129 > Project: ZooKeeper > Issue Type: Improvement > Reporter: Karan Mehta > Priority: Major > > Zookeeper is=C2=A0mostly operated in controlled environments and the clie= nt/server properties are usually known. With this Jira, I would like to pro= pose a new property on client side that represents the max jute buffer size= server is going to accept. > On the ZKClient, in case of multi Op, the request is serialized and hence= we know the size of complete packet that will be sent. We can use this new= property to determine if the we are exceeding the limit and throw some for= m of KeeperException. This would be fail fast mechanism and the application= can potentially retry by chunking up the request or serializing. > Since the same properties are now present in two locations, over time, tw= o possibilities can happen. > -- Server jutebuffer=C2=A0accepts value is more than what is specified on= client side > The application might end up serializing it or zkclient can be made confi= gurable to retry even when it gets this exception > -- Server jutebuffer=C2=A0accepts=C2=A0value is=C2=A0lower than what is s= pecified on client side > That would have failed previously as well, so there is no change in behav= ior > This would help silent failures like HBASE-18549 getting avoided.=C2=A0 > Thoughts [~apurtell] [~xucang] [~anmolnar] [~hanm] -- This message was sent by Atlassian JIRA (v7.6.3#76005)