From dev-return-72507-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Thu Aug 23 09:12:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id B1A0B18061A for ; Thu, 23 Aug 2018 09:12:05 +0200 (CEST) Received: (qmail 55187 invoked by uid 500); 23 Aug 2018 07:12:04 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 55176 invoked by uid 99); 23 Aug 2018 07:12:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Aug 2018 07:12:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 0D8391A07F5 for ; Thu, 23 Aug 2018 07:12:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id nCH-QlH03aan for ; Thu, 23 Aug 2018 07:12:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id EA9155F3F2 for ; Thu, 23 Aug 2018 07:12:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4BD74E015E for ; Thu, 23 Aug 2018 07:12:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 983F1246DB for ; Thu, 23 Aug 2018 07:12:00 +0000 (UTC) Date: Thu, 23 Aug 2018 07:12:00 +0000 (UTC) From: "Hadoop QA (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ZOOKEEPER-3127) Fixing potential data inconsistency due to update last processed zxid with partial multi-op txn MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-3127?page=3Dcom.atlas= sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D= 16589810#comment-16589810 ]=20 Hadoop QA commented on ZOOKEEPER-3127: -------------------------------------- +1 overall. GitHub Pull Request Build =20 +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified test= s. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of java= c compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.= 0.1) warnings. +1 release audit. The applied patch does not increase the total number= of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-b= uild/2084//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github= -pr-build/2084//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings= .html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr= -build/2084//console This message is automatically generated. > Fixing potential data inconsistency due to update last processed zxid wit= h partial multi-op txn > -------------------------------------------------------------------------= ---------------------- > > Key: ZOOKEEPER-3127 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3127 > Project: ZooKeeper > Issue Type: Bug > Components: server > Affects Versions: 3.5.4, 3.6.0, 3.4.13 > Reporter: Fangmin Lv > Priority: Critical > Labels: pull-request-available > Fix For: 3.6.0, 3.5.5, 3.4.14 > > Time Spent: 10m > Remaining Estimate: 0h > > Found this issue while=C2=A0checking the code for another issue, this is = a relatively rare case which we haven't seen it on prod so far. > Currently, the lastProcessedZxid is updated when applying the first txn o= f multi-op, if there is a snapshot in progress, it's possible that the zxid= associated with the snapshot only include partial of the multi op. > When loading snapshot, it will only load the txns after the zxid associat= ed with snapshot file, which could=C2=A0data inconsistency due to missing s= ub txns. > To avoid this, we only update the lastProcessedZxid when the whole multi-= op txn is applied to DataTree. -- This message was sent by Atlassian JIRA (v7.6.3#76005)