From dev-return-72487-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Thu Aug 23 01:33:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 14C0F180677 for ; Thu, 23 Aug 2018 01:33:04 +0200 (CEST) Received: (qmail 84426 invoked by uid 500); 22 Aug 2018 23:33:04 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 84415 invoked by uid 99); 22 Aug 2018 23:33:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Aug 2018 23:33:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 930D6C0115 for ; Wed, 22 Aug 2018 23:33:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id YVsv4qT44VWc for ; Wed, 22 Aug 2018 23:33:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 6FA0A5F398 for ; Wed, 22 Aug 2018 23:33:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E4679E0F39 for ; Wed, 22 Aug 2018 23:33:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 51300246AF for ; Wed, 22 Aug 2018 23:33:00 +0000 (UTC) Date: Wed, 22 Aug 2018 23:33:00 +0000 (UTC) From: "Michael Han (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (ZOOKEEPER-3124) Remove special logic to handle cversion and pzxid in DataTree.processTxn MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-3124?page=3Dcom.atlas= sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D= 16589477#comment-16589477 ]=20 Michael Han edited comment on ZOOKEEPER-3124 at 8/22/18 11:32 PM: ------------------------------------------------------------------ [~lvfangmin] That code was actually added ZOOKEEPER-1046. I think it fixes = the issue of incorrect cversion of parent caused by deleting some of its ch= ildren after taking snapshot (so the deleted nodes never made into the snap= shot which caused problems later while replying tx logs); rather than addin= g children after snapshot is serialized. [~fournc] had a [detailed analysis= |https://issues.apache.org/jira/browse/ZOOKEEPER-1046?focusedCommentId=3D13= 020441&page=3Dcom.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tab= panel#comment-13020441]=C2=A0on this. Does that make sense for you? =C2=A0 The comment in the path that finally landed sounds confusing to me as well. ZOOKEEPER-1269=C2=A0 just moved the same code from one place to the other. was (Author: hanm): [~lvfangmin] That code was actually added ZOOKEEPER-1046. I think it fixes = the issue of incorrect cversion of parent caused by deleting some of its ch= ildren after taking snapshot (so the deleted nodes never made into the snap= shot which caused problems later while replying tx logs); rather than addin= g children after snapshot is serialized. [~fournc] had a detailed analysis= =C2=A0on this. Does that make sense for you? =C2=A0 The comment in the path that finally landed sounds confusing to me as well. ZOOKEEPER-1269=C2=A0 just moved the same code from one place to the other. > Remove special logic to handle cversion and pzxid in DataTree.processTxn > ------------------------------------------------------------------------ > > Key: ZOOKEEPER-3124 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3124 > Project: ZooKeeper > Issue Type: Improvement > Components: server > Reporter: Fangmin Lv > Assignee: Fangmin Lv > Priority: Major > Fix For: 3.6.0 > > > There is special logic in the DataTree.processTxn to handle the NODEEXIST= S when createNode, which is used to handle the cversion and pzxid not being= updated due to fuzzy snapshot:=C2=A0 > https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/= zookeeper/server/DataTree.java#L962-L994.=C2=A0 > But is this a real issue, or is it still an issue for now? > In the current code, when=C2=A0serializing a parent node, we'll lock on i= t, and take a children snapshot at that time. If the child added after the = parent is serialized to disk, then it won't be written out, so we shouldn't= hit the issue where the child is in the snapshot but parent cversion and p= zxid is not changed. > =C2=A0 > =C2=A0 > I checked the=C2=A0JIRA=C2=A0ZOOKEEPER-1269 which added this code, it won= 't hit this issue as well, I'm not sure why we added this, am I missing any= thing? Can we just get rid of it? > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)