From dev-return-72137-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Tue Aug 7 02:33:08 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 00E1C180627 for ; Tue, 7 Aug 2018 02:33:07 +0200 (CEST) Received: (qmail 85452 invoked by uid 500); 7 Aug 2018 00:33:07 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 85441 invoked by uid 99); 7 Aug 2018 00:33:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Aug 2018 00:33:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 723FFC6BB3 for ; Tue, 7 Aug 2018 00:33:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id jQzj5NmJuADh for ; Tue, 7 Aug 2018 00:33:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 2FDD45F206 for ; Tue, 7 Aug 2018 00:33:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6F71AE0026 for ; Tue, 7 Aug 2018 00:33:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0816423F98 for ; Tue, 7 Aug 2018 00:33:00 +0000 (UTC) Date: Tue, 7 Aug 2018 00:33:00 +0000 (UTC) From: "Fangmin Lv (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (ZOOKEEPER-3110) Improve the closeSession throughput in PrepRequestProcessor MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-3110?page=3Dcom.atla= ssian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fangmin Lv updated ZOOKEEPER-3110: ---------------------------------- Description:=20 On leader every expired global session will=C2=A0add 3 lines of logs, which= is pretty heavy and if the log file is more than a few GB,=C2=A0the log=C2= =A0for the closeSession=C2=A0in PrepRequestProcessor will slow down=C2=A0th= e whole ensemble's throughput.=C2=A0 From some=C2=A0use case, we found the prep request processor will be a bott= leneck when there are constantly high number of expired session or=C2=A0clo= sing session explicitly. This=C2=A0JIra is going to remove one of the useless log when prepare close= session txns, which should give us higher throughput during processing lar= ge number of expire sessions. was: On leader every expired global session will=C2=A0add 3 lines of logs, which= is pretty heavy and if the log file is more than a few GB,=C2=A0the log=C2= =A0for the closeSession=C2=A0in PrepRequestProcessor will slow down=C2=A0th= e whole ensemble's throughput.=C2=A0 From some=C2=A0use case, we found the prep request processor will be a bott= leneck when there are constantly high number of expired session or=C2=A0clo= sing session explicitly. This patch=C2=A0is going to remove one of the useless log when prepare clos= e session txns, which should give us higher throughput during processing large number of expire = sessions. > Improve the closeSession throughput in PrepRequestProcessor > ----------------------------------------------------------- > > Key: ZOOKEEPER-3110 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3110 > Project: ZooKeeper > Issue Type: Improvement > Components: quorum > Reporter: Fangmin Lv > Assignee: Fangmin Lv > Priority: Minor > Fix For: 3.6.0 > > > On leader every expired global session will=C2=A0add 3 lines of logs, whi= ch is pretty heavy and if the log file is more than a few GB,=C2=A0the log= =C2=A0for the closeSession=C2=A0in PrepRequestProcessor will slow down=C2= =A0the whole ensemble's throughput.=C2=A0 > From some=C2=A0use case, we found the prep request processor will be a bo= ttleneck when there are constantly high number of expired session or=C2=A0c= losing session explicitly. > This=C2=A0JIra is going to remove one of the useless log when prepare clo= se session txns, which should give us higher throughput during processing l= arge number of expire sessions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)