From dev-return-72205-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Wed Aug 8 19:00:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 58085180676 for ; Wed, 8 Aug 2018 19:00:05 +0200 (CEST) Received: (qmail 27145 invoked by uid 500); 8 Aug 2018 17:00:04 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 27134 invoked by uid 99); 8 Aug 2018 17:00:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Aug 2018 17:00:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id BD3E5C18EE for ; Wed, 8 Aug 2018 17:00:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 0WSsRQ_KLFjS for ; Wed, 8 Aug 2018 17:00:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 7E14E5F545 for ; Wed, 8 Aug 2018 17:00:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B681DE263F for ; Wed, 8 Aug 2018 17:00:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3210D23F9B for ; Wed, 8 Aug 2018 17:00:01 +0000 (UTC) Date: Wed, 8 Aug 2018 17:00:01 +0000 (UTC) From: "Hadoop QA (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ZOOKEEPER-3101) Add comment reminding users to add cases to zerror when adding values to ZOO_ERRORS MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-3101?page=3Dcom.atlas= sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D= 16573504#comment-16573504 ]=20 Hadoop QA commented on ZOOKEEPER-3101: -------------------------------------- +1 overall. GitHub Pull Request Build =20 +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that = doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of java= c compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.= 0.1) warnings. +1 release audit. The applied patch does not increase the total number= of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-b= uild/2039//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github= -pr-build/2039//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings= .html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr= -build/2039//console This message is automatically generated. > Add comment reminding users to add cases to zerror when adding values to = ZOO_ERRORS > -------------------------------------------------------------------------= ---------- > > Key: ZOOKEEPER-3101 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3101 > Project: ZooKeeper > Issue Type: Improvement > Reporter: Kent R. Spillner > Assignee: Kent R. Spillner > Priority: Trivial > Labels: pull-request-available > Time Spent: 1h 20m > Remaining Estimate: 0h > > Add a comment at the bottom of ZOO_ERRORS reminding people to add cases t= o zerror when adding new error values (via=C2=A0https://github.com/apache/z= ookeeper/pull/575#issuecomment-406356144) -- This message was sent by Atlassian JIRA (v7.6.3#76005)